Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add cargo sort check #51

Merged
merged 2 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,17 @@ jobs:
uses: apache/skywalking-eyes/header@v0.5.0

- name: Cargo format
run: cargo fmt --all -- --check
run: make check-fmt

- name: Check diff
run: git diff --exit-code

check_clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Cargo clippy
run: cargo clippy --all-targets --all-features --workspace -- -D warnings
run: make check-clippy

- name: Cargo sort
run: make cargo-sort


build:
runs-on: ${{ matrix.os }}
Expand Down
8 changes: 6 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@
check-fmt:
cargo fmt --all -- --check

clippy:
check-clippy:
cargo clippy --all-targets --all-features --workspace -- -D warnings

check: check-fmt clippy
cargo-sort:
cargo install cargo-sort
cargo sort -c -w

check: check-fmt check-clippy cargo-sort

test:
cargo test --no-fail-fast --all-targets --all-features --workspace
Expand Down
27 changes: 13 additions & 14 deletions crates/iceberg/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,24 @@ license = "Apache-2.0"
keywords = ["iceberg"]

[dependencies]
apache-avro = "0.15"
serde = {version = "^1.0", features = ["rc"]}
serde_bytes = "0.11.8"
serde_json = "^1.0"
serde_derive = "^1.0"
anyhow = "1.0.72"
once_cell = "1"
rust_decimal = "1.31.0"
chrono = "0.4"
uuid = "1.4.1"
ordered-float = "3.7.0"
bitvec = "1.0.1"
serde_repr = "0.1.16"
itertools = "0.11"
apache-avro = "0.15"
bimap = "0.6"
bitvec = "1.0.1"
chrono = "0.4"
derive_builder = "0.12.0"
either = "1"
itertools = "0.11"
lazy_static = "1"

once_cell = "1"
ordered-float = "3.7.0"
rust_decimal = "1.31.0"
serde = { version = "^1.0", features = ["rc"] }
serde_bytes = "0.11.8"
serde_derive = "^1.0"
serde_json = "^1.0"
serde_repr = "0.1.16"
uuid = "1.4.1"

[dev-dependencies]
pretty_assertions = "1.4.0"