feat: Introduce FileIO #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Sep 1, 2023
Xuanwo
reviewed
Sep 1, 2023
JanKaul
reviewed
Sep 1, 2023
Xuanwo
reviewed
Sep 13, 2023
Closed
liurenjie1024
force-pushed
the
renjie/issue-49
branch
from
f055d57 to
f3d6f5a
Compare
Fokko
reviewed
Sep 15, 2023
Fokko
reviewed
Sep 15, 2023
Fokko
reviewed
Sep 15, 2023
Fokko
reviewed
Sep 15, 2023
Fokko
approved these changes
Sep 18, 2023
Xuanwo
reviewed
Sep 19, 2023
|
cc @Fokko I think it's ok to merge? |
|
@liurenjie1024 I believe so, thanks for the review, everyone! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #49
In this pr we implement
FileIOon top of opendal, which provided great abstraction over all kinds of storage. There are still some missing check, but I want to discuss implementation first.