Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata integration tests #57

Merged
merged 13 commits into from
Sep 15, 2023
Merged

Conversation

JanKaul
Copy link
Collaborator

@JanKaul JanKaul commented Sep 8, 2023

This PR adds integration tests for reading the table metadata from files. Some of the tests are designed to fail. With the current design of the serialization/deserialization the error doesn't specify which field is missing. So I couldn't do a precise check for certain tests.

@JanKaul
Copy link
Collaborator Author

JanKaul commented Sep 8, 2023

@liurenjie1024, @Xuanwo , @Fokko it would be great if you could take a look.

@JanKaul JanKaul force-pushed the metadata-integration-tests branch from 9698b27 to a33934e Compare September 8, 2023 07:49
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small suggestion. Thanks, @JanKaul !

crates/iceberg/src/spec/table_metadata.rs Outdated Show resolved Hide resolved
@JanKaul JanKaul force-pushed the metadata-integration-tests branch from 260977d to f57c0ed Compare September 8, 2023 13:00
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @JanKaul, I see a lot of good stuff in this PR, thanks for adding these tests 👍🏻

@Fokko Fokko merged commit e984b1e into apache:main Sep 15, 2023
7 checks passed
@JanKaul JanKaul deleted the metadata-integration-tests branch September 15, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants