Docs: Add flinkVersion and flinkVersionMajor instead of hardcode #10463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
changed the title
manuzhang
force-pushed
the
flink-doc
branch
2 times, most recently
from
cb98d41 to
b6bfab0
Compare
|
@manuzhang: Any idea why the tests are failing on the new values ( |
Fokko
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Thanks @manuzhang for working on this, this looks great! I just noticed that there a few more versions hardcoded:
iceberg_flink_runtime_jar = os.path.join(os.getcwd(), "iceberg-flink-runtime-1.16-{{ icebergVersion }}.jar")There are a few more, would be good to just search for 1.16.
findepi
reviewed
Jun 12, 2024
Fokko
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Looks good, thanks @manuzhang for making this configurable 👍 Thanks @findepi for the review
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10412