Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-11374 Web console: fix frontend dependency audit warnings #6160

Merged
merged 3 commits into from
Feb 25, 2019
Merged

IGNITE-11374 Web console: fix frontend dependency audit warnings #6160

merged 3 commits into from
Feb 25, 2019

Conversation

Klaster1
Copy link
Contributor

nva
nva requested changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@nva nva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm audit still show that frontend has 5 low severity vulnerabilities. Please try to investigate and fix it.

@Klaster1
Copy link
Contributor Author

@nva that's because I didn't add package-lock properly 😅 With it, there's only one low severity vulnerability already addressed here and merged to master, but not released yet. We can update karma later.

@nva nva merged commit 5ca61ae into apache:master Feb 25, 2019
@nva nva deleted the ignite-11374 branch February 25, 2019 04:28
akuznetsov-gridgain pushed a commit to gridgain/apache-ignite that referenced this pull request Feb 25, 2019
@Klaster1 @akuznetsov-os
IGNITE-11374 Web console: fix frontend dependency audit warnings (apa…
8fb8561 
…che#6160)

(cherry picked from commit 5ca61ae)
akuznetsov-gridgain pushed a commit to gridgain/apache-ignite that referenced this pull request Feb 25, 2019
@Klaster1 @akuznetsov-os
IGNITE-11374 Web console: fix frontend dependency audit warnings (apa…
7ba0d8c 
…che#6160)

(cherry picked from commit 5ca61ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nva nva nva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Klaster1 @nva