Theme variables and Positron Scheme #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bchapuis
requested changes
Jun 15, 2023
basemap/layers/aerialway/style.js
Outdated
| @@ -9,6 +9,8 @@ | |||
| or implied. See the License for the specific language governing permissions and limitations under | |||
| the License. | |||
| **/ | |||
| import colorScheme from "../../theme.js"; | |||
There was a problem hiding this comment.
Could you rename colorScheme into theme. We will eventually have more than a color scheme in the theme.
basemap/config.js
Outdated
| @@ -12,7 +12,7 @@ | |||
| export default { | |||
| "host": "http://localhost:9000", | |||
| "database": "jdbc:postgresql://localhost:5432/baremaps?&user=baremaps&password=baremaps", | |||
| "osmPbfUrl": "https://download.geofabrik.de/europe/switzerland-latest.osm.pbf", | |||
| "center": [6.6323, 46.5197], | |||
| "osmPbfUrl": "https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf", | |||
There was a problem hiding this comment.
Could you keep the original file here (switzerland-latest.osm.pbf).
basemap/layers/aeroway/line.js
Outdated
| @@ -10,16 +10,18 @@ | |||
| the License. | |||
| **/ | |||
| import {asLayerObject, withSortKeys} from "../../utils/utils.js"; | |||
| import colorScheme from "../../theme.js"; | |||
basemap/layers/aeroway/polygon.js
Outdated
| @@ -10,11 +10,12 @@ | |||
| the License. | |||
| **/ | |||
| import {asLayerObject, withSortKeys} from "../../utils/utils.js"; | |||
| import colorScheme from "../../theme.js"; | |||
basemap/layers/amenity/background.js
Outdated
| @@ -10,31 +10,32 @@ | |||
| the License. | |||
| **/ | |||
| import {asLayerObject, withSortKeys} from "../../utils/utils.js"; | |||
| import colorScheme from "../../theme.js"; | |||
basemap/layers/barrier/style.js
Outdated
| @@ -9,6 +9,8 @@ | |||
| or implied. See the License for the specific language governing permissions and limitations under | |||
| the License. | |||
| **/ | |||
| import colorScheme from "../../theme.js"; | |||
basemap/themes/default.js
Outdated
| @@ -0,0 +1,608 @@ | |||
| export default { | |||
|
|
|||
basemap/themes/default.js
Outdated
| landuseOverlayOrchardFillColor: 'rgb(172, 225, 161)', | ||
| pointCountryLabelCountryTextColor: 'rgb(90, 56, 90)', | ||
| pointCountryLabelPaintTextHaloColor: 'rgba(255, 255, 255, 0.8)', | ||
| LeisureBackgroundSwimmingPoolFillColor: 'rgb(170, 211, 223)', |
basemap/themes/light.js
Outdated
| import * as importedTools from "./tools.js"; | ||
| import positronScheme from "./positron.js"; | ||
|
|
||
| const CLARITYFACTOR=4.7; |
MaximeLesti
force-pushed
the
theme-variables
branch
from
5ed2549 to
fce7735
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bchapuis
approved these changes
Jun 15, 2023
|
Thanks a lot for the changes, this is a great addition to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List color variables and add a positron scheme