Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize postgres tilestore #792

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Optimize postgres tilestore #792

merged 6 commits into from
Oct 27, 2023

Conversation

bchapuis
Copy link
Member

No description provided.

@bchapuis bchapuis force-pushed the optimize-postgres-tilestore branch from c7ce774 to 13d3776 Compare October 24, 2023 10:12
@bchapuis bchapuis force-pushed the optimize-postgres-tilestore branch from 3f5dc06 to cdb0e85 Compare October 25, 2023 11:27
@bchapuis bchapuis force-pushed the optimize-postgres-tilestore branch from aaf81d1 to 9b469f4 Compare October 25, 2023 11:38
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

/**
* A record that holds the sql of a prepared statement and the number of parameters.
*
* @param sql

Check notice

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "sql" does not match any actual type parameter of type "Query".
* A record that holds the sql of a prepared statement and the number of parameters.
*
* @param sql
* @param parameters

Check notice

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "parameters" does not match any actual type parameter of type "Query".
@bchapuis
Copy link
Member Author

bchapuis commented Oct 26, 2023

This PR align the queries generated by the PostgresTileStore to the queries generated by the baremaps-exporter. There is still room to optimize the performance but it is a good first step. In addition, it greatly simplifies the code.

@polastre Would you mind if I add you as a co-author for the squash commit?

@polastre
Copy link
Contributor

@bchapuis all good with me 👍

@bchapuis bchapuis merged commit 647a273 into main Oct 27, 2023
10 checks passed
@bchapuis bchapuis deleted the optimize-postgres-tilestore branch October 27, 2023 09:26
@bchapuis
Copy link
Member Author

This is great! The queries are now much simpler and I suspect they will work out of the box with Apache Calcite as we don't use ST_Dump anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants