Exclude Draft Releases in ReleaseExtractor #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
klesh
reviewed
Nov 26, 2024
| @@ -55,7 +55,9 @@ func ExtractReleases(taskCtx plugin.SubTaskContext) errors.Error { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if release.IsDraft { | |||
| return nil, nil | |||
There was a problem hiding this comment.
golang lint failed, I think it was caused by the trailing spaces, can you remove them?
There was a problem hiding this comment.
Fixed it, but had to force push since the commit message lint failed as well.
Draft releases lead to a bug described in GH Issue apache#8148
|
Thanks for your contribution, would you like to create another PR to the release-v1.0 branch so it can be released faster. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exclude Draft Releases in ReleaseExtractor to avoid bug due to malformed PublishedAt field.
Does this close any open issues?
Closes #8148