-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AnnotationBean.java delete duplicate code #3021
Conversation
delete useless code
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
==========================================
+ Coverage 64.24% 64.33% +0.08%
==========================================
Files 584 584
Lines 26056 26056
Branches 4562 4562
==========================================
+ Hits 16740 16762 +22
+ Misses 7132 7111 -21
+ Partials 2184 2183 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what it looks like
I don't quite understand. |
Looks good to me. |
AnnotationBean is deprecated, never should be used again. |
delete useless code
delete useless code
What is the purpose of the change
delete useless code
Brief changelog
XXXXX
duplicate code
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.