You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had searched in the issues and found no similar issues.
Enhancement Request
There are almost same code for updating client infos and subscriptions in org.apache.eventmesh.runtime.core.protocol.http.processor.LocalSubscribeEventProcessor and org.apache.eventmesh.runtime.core.protocol.http.processor.SubscribeProcessor.
In deatils,
the local method registerClient in both Processor
the code in SubscribeProcessor(line192-263) and LocalSubscribeEventProcessor(line176-247)
It is better to manage the code to "update client info" and "update subscription info" in the same code block or a manager.
Describe the solution you'd like
Maybe we can:
step1: add a manager to manage client info and subscription, for example SubscriptionManager;
step2: consider wether we can combine consumerManager and SubscriptionManager together to manager all info in consumer side.
Are you willing to submit PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered:
Search before asking
Enhancement Request
There are almost same code for updating client infos and subscriptions in
org.apache.eventmesh.runtime.core.protocol.http.processor.LocalSubscribeEventProcessor
andorg.apache.eventmesh.runtime.core.protocol.http.processor.SubscribeProcessor
.In deatils,
registerClient
in both ProcessorIt is better to manage the code to "update client info" and "update subscription info" in the same code block or a manager.
Describe the solution you'd like
Maybe we can:
step1: add a manager to manage client info and subscription, for example
SubscriptionManager
;step2: consider wether we can combine
consumerManager
andSubscriptionManager
together to manager all info in consumer side.Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: