Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] update pacakge.sh for spark34 #3786

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

zhouyuan
Copy link
Contributor

What changes were proposed in this pull request?

update pacakge.sh to cover spark34

How was this patch tested?

no tests required

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@@ -12,6 +12,7 @@ VERSION=$(. /etc/os-release && echo ${VERSION_ID})
$GLUTEN_DIR/dev/builddeps-veloxbe.sh --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON
mvn clean package -Pbackends-velox -Prss -Pspark-3.2 -DskipTests
mvn clean package -Pbackends-velox -Prss -Pspark-3.3 -DskipTests
mvn clean package -Pbackends-velox -Prss -Pspark-3.4 -DskipTests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JkSelf this is missed when enabling spark34

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

@zhouyuan zhouyuan merged commit b22c862 into apache:main Nov 21, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3786_time.csv log/native_master_11_20_2023_60fc2a02e_time.csv difference percentage
q1 34.48 34.37 -0.115 99.67%
q2 24.77 24.70 -0.071 99.71%
q3 37.39 35.40 -1.991 94.67%
q4 34.96 36.40 1.433 104.10%
q5 70.83 68.86 -1.973 97.21%
q6 6.01 7.01 1.007 116.77%
q7 85.01 85.39 0.378 100.44%
q8 87.30 87.44 0.131 100.15%
q9 121.41 124.93 3.518 102.90%
q10 43.89 46.83 2.937 106.69%
q11 19.97 19.99 0.026 100.13%
q12 28.05 24.57 -3.476 87.61%
q13 45.97 44.85 -1.114 97.58%
q14 14.24 18.77 4.529 131.80%
q15 29.36 27.13 -2.229 92.41%
q16 15.39 15.41 0.023 100.15%
q17 100.69 102.21 1.518 101.51%
q18 148.58 149.83 1.253 100.84%
q19 13.00 13.48 0.472 103.63%
q20 27.06 28.10 1.037 103.83%
q21 221.56 220.09 -1.462 99.34%
q22 13.06 12.89 -0.174 98.67%
total 1222.99 1228.65 5.659 100.46%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants