-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] update pacakge.sh for spark34 #3786
Conversation
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@@ -12,6 +12,7 @@ VERSION=$(. /etc/os-release && echo ${VERSION_ID}) | |||
$GLUTEN_DIR/dev/builddeps-veloxbe.sh --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON | |||
mvn clean package -Pbackends-velox -Prss -Pspark-3.2 -DskipTests | |||
mvn clean package -Pbackends-velox -Prss -Pspark-3.3 -DskipTests | |||
mvn clean package -Pbackends-velox -Prss -Pspark-3.4 -DskipTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JkSelf this is missed when enabling spark34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
update pacakge.sh to cover spark34
How was this patch tested?
no tests required