-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3855][VL] Fix ORC related failed UT #3805
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
9f87a54
to
f7ecae5
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
c30246a
to
5ac8762
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
fbf7d90
to
1bc0517
Compare
Run Gluten Clickhouse CI |
@JkSelf all unit ORC tests are passing, it should safe to include oap-project/velox#417 now |
@chenxu14 The tests under |
I see |
1bc0517
to
b01cf3d
Compare
Run Gluten Clickhouse CI |
b01cf3d
to
c3bcc89
Compare
Run Gluten Clickhouse CI |
Can you help me to determine if the failed UT is related to ORC @rui-mo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenxu14 Thanks for trying to enable more tests. Seems there is only 1 failed test on Spark 3.3, but several failures on Spark 3.4. Maybe there are some new issues on Spark 3.4 because its framework was introduced weeks ago. Could you disable the failed ones especially on Spark 3.4 first?
cc @JkSelf
.exclude("SPARK-15474 Write and read back non-empty schema with empty dataframe - orc") | ||
.exclude("SPARK-23271 empty RDD when saved should write a metadata only file - orc") | ||
.exclude("SPARK-22146 read files containing special characters using orc") | ||
.exclude("SPARK-30362: test input metrics for DSV2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe exclude SPARK-30362: test input metrics for DSV2
with below message.
// Unknown. Need to investigate.
c3bcc89
to
e361ed0
Compare
Run Gluten Clickhouse CI |
e361ed0
to
63e8f7b
Compare
Run Gluten Clickhouse CI |
63e8f7b
to
622e351
Compare
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Run Gluten Clickhouse CI |
@chenxu14 thank you for fixing the ORC tests! |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Fix ORC related failed UT, below two tests were not fixed - will fix them in following commits
How was this patch tested?
pass GHA