[VL] Support ignoreNulls for NthValue window function #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
rui-mo
approved these changes
Nov 29, 2023
rui-mo
reviewed
Nov 29, 2023
| val frame = wExpression.windowSpec.frameSpecification.asInstanceOf[SpecifiedWindowFrame] | ||
| val childrenNodeList = new JArrayList[ExpressionNode]() | ||
| childrenNodeList.add( | ||
| ExpressionConverter | ||
| .replaceWithExpressionTransformer(input, attributeSeq = originalInputAttributes) | ||
| .doTransform(args)) | ||
| childrenNodeList.add(LiteralTransformer(offset).doTransform(args)) | ||
| childrenNodeList.add(LiteralTransformer(Literal(ignoreNulls)).doTransform(args)) |
There was a problem hiding this comment.
You could use makeLiteral to get an expression node.
There was a problem hiding this comment.
Will fix it in a separate PR. Thanks!
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this patch tested?
Spark UTs & a new test added.