Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-2169][VL] Enable GlutenEnsureRequirementsSuite in unit tests #3860

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Nov 28, 2023

What changes were proposed in this pull request?

Enable spark 3,3 and 3.4 unit test

enableSuite[GlutenEnsureRequirementsSuite]
    // FIXME: yan
    .exclude("reorder should handle PartitioningCollection")

How was this patch tested?

Existing unit tests.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@zhouyuan
Copy link
Contributor

@JkSelf can you also enable this in Spark34?

thanks, -yuan

Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan changed the title [VL] Enable GlutenEnsureRequirementsSuite [GLUTEN-2169][VL] Enable GlutenEnsureRequirementsSuite Nov 28, 2023
@zhouyuan zhouyuan changed the title [GLUTEN-2169][VL] Enable GlutenEnsureRequirementsSuite [GLUTEN-2169][VL] Enable GlutenEnsureRequirementsSuite in unit tests Nov 28, 2023
Copy link

#2169

@zhouyuan zhouyuan merged commit a55ab51 into apache:main Nov 28, 2023
20 checks passed
zhouyuan pushed a commit that referenced this pull request Nov 28, 2023
…3860)

* Enable GlutenEnsureRequirementsSuite

* Enable GlutenEnsureRequirementsSuite in spark 34
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3860_time.csv log/native_master_11_27_2023_08cdbee7e_time.csv difference percentage
q1 33.77 33.96 0.193 100.57%
q2 23.31 24.50 1.191 105.11%
q3 36.15 36.70 0.551 101.52%
q4 38.40 36.44 -1.959 94.90%
q5 71.90 70.50 -1.399 98.05%
q6 6.78 7.29 0.512 107.56%
q7 88.11 83.48 -4.630 94.74%
q8 87.64 88.10 0.464 100.53%
q9 126.23 122.04 -4.196 96.68%
q10 47.67 46.95 -0.728 98.47%
q11 20.44 19.82 -0.620 96.97%
q12 23.38 26.08 2.694 111.52%
q13 45.93 48.07 2.132 104.64%
q14 18.80 15.26 -3.540 81.17%
q15 27.60 28.91 1.311 104.75%
q16 15.86 15.89 0.034 100.21%
q17 103.09 103.54 0.449 100.44%
q18 151.25 151.52 0.267 100.18%
q19 13.26 12.96 -0.299 97.75%
q20 28.04 28.70 0.659 102.35%
q21 224.99 226.06 1.070 100.48%
q22 13.49 13.19 -0.299 97.78%
total 1246.10 1239.96 -6.142 99.51%

@guixiaowen
Copy link
Contributor

@JkSelf can you also enable this in Spark34?

thanks, -yuan

@JkSelf Sorry to bother you, may I ask why this UT is not also enabled in 3.2? Because I see that 3.2 is already supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants