-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3865][CH] Refactor aggregating without keys #3866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 28, 2023 09:46
a1bee12
to
1e8f7dd
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 28, 2023 09:47
1e8f7dd
to
fb17ff4
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 28, 2023 09:48
fb17ff4
to
959febf
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 29, 2023 00:33
959febf
to
2683a26
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 29, 2023 02:37
2683a26
to
f578dfa
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 29, 2023 07:28
f578dfa
to
11a745b
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 29, 2023 09:56
11a745b
to
cc49f93
Compare
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
empty_aggregated_result
branch
from
November 29, 2023 11:00
cc49f93
to
7fa3883
Compare
Run Gluten Clickhouse CI |
liuneng1994
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #3865
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)