Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Minor improvements for CI stale bot #3888

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 30, 2023

  1. Leave comments on issues as well as on PRs. Disable auto-close on issues.
  2. Note user to feel free to reopen.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

stale-issue-message: 'This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.'
close-issue-message: 'This issue was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it's still valid. Thanks.'
days-before-stale: 45
days-before-close: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer do not close issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/stale closes issues by default... So let's disable it in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. this one

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit 9d07d48 into apache:main Dec 5, 2023
17 of 18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3888_time.csv log/native_master_12_04_2023_94c91c55d_time.csv difference percentage
q1 33.62 34.65 1.031 103.07%
q2 23.61 24.91 1.300 105.51%
q3 37.22 36.38 -0.841 97.74%
q4 37.22 37.37 0.150 100.40%
q5 70.27 72.63 2.357 103.35%
q6 6.74 6.87 0.126 101.87%
q7 84.84 85.44 0.598 100.71%
q8 87.01 87.86 0.856 100.98%
q9 123.09 124.52 1.434 101.16%
q10 45.62 46.04 0.419 100.92%
q11 21.46 20.12 -1.330 93.80%
q12 24.61 26.71 2.093 108.50%
q13 45.59 46.45 0.863 101.89%
q14 17.88 14.55 -3.330 81.37%
q15 29.19 28.16 -1.035 96.46%
q16 15.64 15.75 0.109 100.70%
q17 102.18 103.10 0.921 100.90%
q18 151.39 150.63 -0.757 99.50%
q19 13.80 12.90 -0.902 93.46%
q20 27.74 27.73 -0.010 99.96%
q21 223.99 222.80 -1.191 99.47%
q22 13.20 13.06 -0.143 98.92%
total 1235.91 1238.63 2.718 100.22%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants