Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] ENABLE_EP_CACHE=ON still uses cached Velox build although the build arguments were changed #3926

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Dec 5, 2023

Prior to this fix, ENABLE_EP_CACHE=ON only uses the target commit hash as cache key, which means for example, when we change BUILD_TYPE from Debug to Release, the cached debug build is still used as cached build incorrectly.

This patch is a fix for the bug.

@zhztheplayer zhztheplayer changed the title [VL] ENABLE_EP_CACHE still uses cached Velox build although the build argument was changed [VL] ENABLE_EP_CACHE=ON still uses cached Velox build although the build argument was changed Dec 5, 2023
@zhztheplayer zhztheplayer changed the title [VL] ENABLE_EP_CACHE=ON still uses cached Velox build although the build argument was changed [VL] ENABLE_EP_CACHE=ON still uses cached Velox build although the build arguments were changed Dec 5, 2023
@apache apache deleted a comment from github-actions bot Dec 5, 2023
@zhztheplayer
Copy link
Member Author

@zhouyuan

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit e0a10bf into apache:main Dec 6, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3926_time.csv log/native_master_12_05_2023_a46243420_time.csv difference percentage
q1 32.37 34.72 2.352 107.27%
q2 25.81 25.00 -0.810 96.86%
q3 36.00 37.98 1.982 105.51%
q4 37.90 38.25 0.356 100.94%
q5 70.74 72.06 1.320 101.87%
q6 7.05 5.37 -1.679 76.17%
q7 86.11 82.30 -3.813 95.57%
q8 86.94 86.96 0.013 100.02%
q9 127.43 126.92 -0.501 99.61%
q10 44.55 45.43 0.877 101.97%
q11 20.28 20.31 0.031 100.15%
q12 26.36 27.02 0.659 102.50%
q13 47.08 47.15 0.070 100.15%
q14 15.77 19.01 3.238 120.53%
q15 27.07 29.59 2.520 109.31%
q16 15.51 15.81 0.298 101.92%
q17 103.31 103.87 0.560 100.54%
q18 151.13 150.70 -0.434 99.71%
q19 14.34 14.53 0.190 101.33%
q20 27.86 28.18 0.324 101.16%
q21 224.64 223.72 -0.918 99.59%
q22 13.07 13.17 0.101 100.78%
total 1241.31 1248.05 6.734 100.54%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants