Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import #3940

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import #3940

merged 1 commit into from
Dec 6, 2023

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Fix SparkShimLoader not found.

How was this patch tested?

Pass CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

#3917

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Run Gluten Clickhouse CI

@ulysses-you ulysses-you mentioned this pull request Dec 6, 2023
Merged
PHILO-HE
PHILO-HE approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

@JkSelf
Copy link
Contributor

JkSelf commented Dec 6, 2023

@ulysses-you Thanks for your quickly fix!

JkSelf
JkSelf approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ulysses-you
Copy link
Contributor Author

The build step is passed, I'm merging it to unblock CI.

@ulysses-you ulysses-you merged commit 81bb6c9 into apache:main Dec 6, 2023
16 of 17 checks passed
@ulysses-you ulysses-you deleted the fix branch December 6, 2023 04:13
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3940_time.csv log/native_master_12_05_2023_a46243420_time.csv difference percentage
q1 33.57 34.72 1.154 103.44%
q2 25.03 25.00 -0.025 99.90%
q3 37.81 37.98 0.163 100.43%
q4 37.73 38.25 0.522 101.38%
q5 70.12 72.06 1.944 102.77%
q6 7.04 5.37 -1.670 76.27%
q7 85.62 82.30 -3.326 96.12%
q8 87.43 86.96 -0.479 99.45%
q9 126.56 126.92 0.370 100.29%
q10 45.67 45.43 -0.240 99.47%
q11 20.39 20.31 -0.083 99.59%
q12 26.52 27.02 0.499 101.88%
q13 47.00 47.15 0.152 100.32%
q14 16.22 19.01 2.787 117.18%
q15 27.01 29.59 2.576 109.53%
q16 15.63 15.81 0.178 101.14%
q17 102.60 103.87 1.275 101.24%
q18 150.05 150.70 0.649 100.43%
q19 13.77 14.53 0.756 105.49%
q20 27.23 28.18 0.946 103.47%
q21 223.18 223.72 0.541 100.24%
q22 13.01 13.17 0.161 101.24%
total 1239.20 1248.05 8.849 100.71%

loneylee pushed a commit to loneylee/gluten that referenced this pull request Dec 7, 2023
@ulysses-you @loneylee
[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import (apache#3940)
edddb9e
loneylee pushed a commit to loneylee/gluten that referenced this pull request Dec 7, 2023
@ulysses-you @loneylee
[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import (apache#3940)
cc4bb7c
loneylee added a commit to loneylee/gluten that referenced this pull request Dec 8, 2023
@loneylee
Revert "[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import (apac…
09b8ffb 
…he#3940)"

This reverts commit 81bb6c9.
baibaichen pushed a commit that referenced this pull request Dec 8, 2023
@loneylee
Revert "[VL] Make bloom_filter_agg fall back when might_contain is no…
e9ea4e3 
…t transformable (#3917)" (#3977)

* Revert "[VL] Make bloom_filter_agg fall back when might_contain is not transformable (#3917)"

This reverts commit d7d8e28.

* Revert "[GLUTEN-3917][FOLLOWUP] Add back SparkShimLoader import (#3940)"

This reverts commit 81bb6c9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHILO-HE PHILO-HE PHILO-HE approved these changes

@JkSelf JkSelf JkSelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ulysses-you @JkSelf @GlutenPerfBot @PHILO-HE