Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix wrong fallback cost #3967

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Since we have removed AQE columnar shuffle read, so it's possible the gluten plan and query stage are not adjacent. This pr changes to collect leaves for gluten plan to make code robust.

How was this patch tested?

add test

Copy link

github-actions bot commented Dec 7, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

cc @PHILO-HE thank you

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!
We are fixing CI issue. Stay tuned.

@ulysses-you ulysses-you merged commit 1b1d0d3 into apache:main Dec 7, 2023
15 of 17 checks passed
@ulysses-you ulysses-you deleted the fallbac branch December 7, 2023 07:42
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3967_time.csv log/native_master_12_06_2023_d6b1e9138_time.csv difference percentage
q1 33.65 33.13 -0.519 98.46%
q2 24.61 25.88 1.273 105.17%
q3 38.50 36.12 -2.382 93.81%
q4 36.88 38.73 1.848 105.01%
q5 71.68 72.19 0.507 100.71%
q6 5.50 7.01 1.510 127.43%
q7 85.84 84.85 -0.991 98.85%
q8 86.79 87.08 0.284 100.33%
q9 123.73 127.07 3.344 102.70%
q10 44.76 44.57 -0.190 99.57%
q11 20.51 20.26 -0.251 98.78%
q12 24.97 21.15 -3.827 84.68%
q13 46.70 48.39 1.694 103.63%
q14 16.06 18.86 2.800 117.44%
q15 28.81 27.18 -1.622 94.37%
q16 15.64 15.92 0.280 101.79%
q17 102.62 102.54 -0.086 99.92%
q18 151.42 152.02 0.607 100.40%
q19 12.94 13.90 0.957 107.39%
q20 28.69 27.91 -0.782 97.27%
q21 223.35 223.84 0.482 100.22%
q22 13.15 13.24 0.090 100.68%
total 1236.81 1241.84 5.027 100.41%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants