Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Make bloom_filter_agg fall back when might_contain is not transformable #3994

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Dec 11, 2023

What changes were proposed in this pull request?

  1. Reapply the change "[VL] Make bloom_filter_agg fall back when might_contain is not transformable".
  2. Fix the issue only might_contain fallback.
  3. Add flag to disable this in CK.
  4. Add more UTs.

How was this patch tested?

UT.

@zhli1142015
Copy link
Contributor Author

cc @zhouyuan , @baibaichen , thanks.

Copy link

Run Gluten Clickhouse CI

@zhouyuan
Copy link
Contributor

CC: @loneylee

Copy link

Run Gluten Clickhouse CI

@zhli1142015 zhli1142015 force-pushed the bloom_filter_fallback_2 branch from 14d9979 to 301d4ed Compare December 11, 2023 05:30
Copy link

Run Gluten Clickhouse CI

@zhli1142015
Copy link
Contributor Author

@zhouyuan , @baibaichen , are you ok to reapply this change?
@baibaichen and @loneylee , bloom_filter_agg fallback rule is disabled for CK so there is no impact to you. You can remove the flag enableBloomFilterAggFallbackRule after you confirm this change works ok for CK.
Thanks.

}
}

plan.transformExpressions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhli1142015 is this the key change?

Fix the issue only might_contain fallback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 11, 2023
@zhli1142015 zhli1142015 merged commit 71ec720 into apache:main Dec 11, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_11_2023_time.csv log/native_master_12_10_2023_e9ea4e3e4_time.csv difference percentage
q1 32.10 34.68 2.581 108.04%
q2 24.79 27.19 2.406 109.71%
q3 38.42 37.58 -0.845 97.80%
q4 39.90 37.98 -1.924 95.18%
q5 72.41 70.50 -1.910 97.36%
q6 7.02 6.93 -0.089 98.73%
q7 85.38 84.23 -1.149 98.65%
q8 86.65 85.45 -1.196 98.62%
q9 126.76 126.22 -0.534 99.58%
q10 46.79 43.28 -3.514 92.49%
q11 20.34 19.94 -0.404 98.01%
q12 26.95 27.48 0.527 101.95%
q13 45.56 47.58 2.017 104.43%
q14 18.31 16.51 -1.797 90.18%
q15 27.78 27.43 -0.347 98.75%
q16 15.83 15.68 -0.148 99.07%
q17 101.57 104.55 2.983 102.94%
q18 151.54 149.27 -2.276 98.50%
q19 12.91 13.60 0.691 105.35%
q20 26.84 27.18 0.344 101.28%
q21 228.06 225.87 -2.192 99.04%
q22 13.81 13.10 -0.712 94.85%
total 1249.71 1242.22 -7.488 99.40%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants