-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Make bloom_filter_agg fall back when might_contain is not transformable #3994
Conversation
cc @zhouyuan , @baibaichen , thanks. |
Run Gluten Clickhouse CI |
CC: @loneylee |
Run Gluten Clickhouse CI |
14d9979
to
301d4ed
Compare
Run Gluten Clickhouse CI |
@zhouyuan , @baibaichen , are you ok to reapply this change? |
} | ||
} | ||
|
||
plan.transformExpressions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhli1142015 is this the key change?
Fix the issue only might_contain fallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…ight_contain is not transformable
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
How was this patch tested?
UT.