[Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
FelixYBW
changed the title
binmahone
changed the title
binmahone
force-pushed
the
check_wenzheng_CD_formain
branch
from
308c7a2 to
dd255f4
Compare
|
Run Gluten Clickhouse CI |
binmahone
force-pushed
the
check_wenzheng_CD_formain
branch
from
dd255f4 to
32300b5
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
binmahone
force-pushed
the
check_wenzheng_CD_formain
branch
from
32300b5 to
7e7a0ec
Compare
|
Run Gluten Clickhouse CI |
zzcclp
reviewed
Mar 12, 2024
| } | ||
| } | ||
|
|
||
| { |
zzcclp
reviewed
Mar 12, 2024
| .getAttrsIndexForExtensionAggregateExpr( | ||
| aggregateFunc, | ||
| exp.mode, | ||
| exp, | ||
| aggregateAttributeList, | ||
| aggregateAttr, | ||
| index) | ||
| } else { | ||
| if (option.nonEmpty) { | ||
| return option.get |
There was a problem hiding this comment.
why it needs return directly?
binmahone
force-pushed
the
check_wenzheng_CD_formain
branch
from
7e7a0ec to
43204a5
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
binmahone
force-pushed
the
check_wenzheng_CD_formain
branch
from
43204a5 to
226cc0b
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Mar 25, 2024
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Oct 8, 2024
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f Expand+Count
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #4706)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)