Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4039][VL] support map_keys and map_values #4826

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

konjac
Copy link
Contributor

@konjac konjac commented Mar 1, 2024

What changes were proposed in this pull request?

Enable map_keys and map_values

#4039 (comment)

How was this patch tested?

Manually test and unit test

Copy link

github-actions bot commented Mar 1, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@konjac konjac changed the title [VL] map_keys and map_values support [GLUTEN-4039][VL][UT]feat: support map_keys and map_values Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

#4039

@zhli1142015 zhli1142015 changed the title [GLUTEN-4039][VL][UT]feat: support map_keys and map_values [GLUTEN-4039][VL] support map_keys and map_values Mar 1, 2024
@konjac konjac marked this pull request as ready for review March 1, 2024 08:05
@konjac
Copy link
Contributor Author

konjac commented Mar 4, 2024

@PHILO-HE Could you help to have a review?

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zhli1142015 zhli1142015 merged commit bca0325 into apache:main Mar 4, 2024
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4826_time.csv log/native_master_03_03_2024_6b5ee6971_time.csv difference percentage
q1 32.65 36.61 3.959 112.13%
q2 24.19 24.50 0.305 101.26%
q3 37.74 39.42 1.678 104.45%
q4 38.16 38.53 0.371 100.97%
q5 71.87 70.78 -1.093 98.48%
q6 6.98 7.30 0.324 104.64%
q7 86.28 84.97 -1.316 98.47%
q8 84.79 84.52 -0.274 99.68%
q9 121.94 121.76 -0.181 99.85%
q10 41.81 44.77 2.961 107.08%
q11 20.63 20.74 0.108 100.52%
q12 25.45 29.46 4.010 115.75%
q13 45.33 45.96 0.635 101.40%
q14 20.15 21.41 1.263 106.27%
q15 30.04 27.97 -2.072 93.10%
q16 14.43 13.22 -1.210 91.62%
q17 102.76 103.13 0.368 100.36%
q18 149.21 146.21 -3.000 97.99%
q19 12.52 13.66 1.146 109.15%
q20 28.46 26.57 -1.887 93.37%
q21 224.83 225.15 0.314 100.14%
q22 14.83 13.79 -1.046 92.95%
total 1235.05 1240.41 5.360 100.43%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants