[GLUTEN-4831][VL] Support StructType in HashAggregate #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
2 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
PHILO-HE
reviewed
Mar 6, 2024
| @@ -99,6 +99,7 @@ abstract class HashAggregateExecBaseTransformer( | |||
| true | |||
| case _: NumericType => true | |||
| case _: ArrayType => true | |||
| case s: StructType => true | |||
There was a problem hiding this comment.
fixed and rebased. thanks.
WangGuangxin
force-pushed
the
feat_groupby_structtype
branch
from
66e800c to
9bdb5a9
Compare
|
Run Gluten Clickhouse CI |
PHILO-HE
approved these changes
Mar 7, 2024
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Mar 25, 2024
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Oct 8, 2024
taiyang-li
pushed a commit
to bigo-sg/gluten
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support StructType in HashAggregate
(Fixes: #4831)