[GLUTEN-4835][CORE] Match metric names with Spark

[clee704]

What changes were proposed in this pull request?

Rename metrics "inputRows" and "outputRows" to "numInputRows" and "numOutputRows" respectively, to match the names used in Spark.

(Fixes: #4835)

How was this patch tested?

Added a test case under GlutenSQLQuerySuite

[github-actions]

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

[github-actions]

Run Gluten Clickhouse CI

[zhli1142015]

Thanks, could you open an issue for this, to describe why need this change.

[clee704]

I'll create one. Here's the short answer - it breaks some Spark internal things due to the mismatch of metric names.

[github-actions]

Run Gluten Clickhouse CI

[github-actions]

Run Gluten Clickhouse CI

[github-actions]

#4835

[github-actions]

Run Gluten Clickhouse CI

[zhli1142015]

Thanks.

[zhli1142015]

cc @zhouyuan and @zzcclp , thanks.

[github-actions]

Run Gluten Clickhouse CI

[github-actions]

Run Gluten Clickhouse CI

[zhouyuan]

The patch looks good to me. Indeed we didnt pay much attention on the Spark built metrics/instrumentation system.
CC @rui-mo can you please also take a look?

[rui-mo]

@FelixYBW Do you think this change makes sense? Thanks.

[FelixYBW]

Yes, looks the names are inherited from Gazelle. Not sure why we don't use spark standard name

[ulysses-you]

+1, lgtm

[zhli1142015]

Thanks.

[rui-mo]

@zzcclp Please help confirm on CH backend, thanks!

[GlutenPerfBot]

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query	log/native_4834_time.csv	log/native_master_03_10_2024_3ad58ce14_time.csv	difference	percentage
q1	35.67	35.86	0.189	100.53%
q2	23.59	25.95	2.357	109.99%
q3	38.26	36.82	-1.439	96.24%
q4	37.67	38.96	1.291	103.43%
q5	69.63	70.83	1.193	101.71%
q6	7.47	7.41	-0.057	99.23%
q7	82.40	83.10	0.700	100.85%
q8	85.74	85.35	-0.385	99.55%
q9	121.63	118.73	-2.892	97.62%
q10	45.86	42.98	-2.879	93.72%
q11	20.19	21.60	1.413	107.00%
q12	26.90	25.06	-1.841	93.15%
q13	47.84	46.55	-1.289	97.31%
q14	16.67	19.73	3.058	118.34%
q15	29.17	32.39	3.213	111.02%
q16	12.79	13.72	0.931	107.28%
q17	101.53	100.46	-1.071	98.95%
q18	142.37	142.43	0.069	100.05%
q19	15.20	13.62	-1.581	89.60%
q20	27.38	26.87	-0.512	98.13%
q21	224.48	225.05	0.564	100.25%
q22	13.91	14.04	0.130	100.94%
total	1226.32	1227.48	1.162	100.09%