Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Merge Partial and PartialMerge logic in generateMergeCompanionNode #4883

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

Merge Partial and PartialMerge logic in generateMergeCompanionNode.

How was this patch tested?

Exists CI.

Copy link

github-actions bot commented Mar 7, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

cc @ulysses-you, @PHILO-HE, thanks.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulysses-you ulysses-you merged commit 879ea76 into apache:main Mar 8, 2024
18 checks passed
@liujiayi771 liujiayi771 deleted the companion branch March 8, 2024 02:17
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4883_time.csv log/native_master_03_06_2024_bddc3fd79_time.csv difference percentage
q1 36.89 38.77 1.878 105.09%
q2 23.82 24.36 0.533 102.24%
q3 36.79 39.60 2.808 107.63%
q4 37.78 37.58 -0.201 99.47%
q5 69.17 69.92 0.756 101.09%
q6 7.54 8.34 0.794 110.53%
q7 83.62 84.40 0.781 100.93%
q8 85.61 86.73 1.127 101.32%
q9 121.70 119.49 -2.215 98.18%
q10 42.89 43.18 0.291 100.68%
q11 20.43 20.86 0.429 102.10%
q12 29.38 28.05 -1.323 95.50%
q13 46.42 44.55 -1.877 95.96%
q14 23.52 17.03 -6.487 72.42%
q15 31.33 28.15 -3.188 89.83%
q16 14.69 14.07 -0.611 95.84%
q17 102.09 101.46 -0.631 99.38%
q18 144.11 145.26 1.157 100.80%
q19 14.74 13.99 -0.752 94.90%
q20 28.63 28.21 -0.419 98.54%
q21 229.99 224.18 -5.808 97.47%
q22 15.25 14.99 -0.262 98.28%
total 1246.40 1233.17 -13.223 98.94%

taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Mar 25, 2024
taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Oct 8, 2024
taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants