Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update release & configuration doc #4910

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Mar 11, 2024

Also replaced oap-project/gluten with apache/incubator-gluten in doc.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@PHILO-HE
Copy link
Contributor Author

@weiting-chen, could you take a review? Thanks!

docs/release.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also change the archived releases url to https://github.com/apache/incubator-gluten/releases/tag/

@@ -1,4 +1,4 @@
# Gluten: Plugin to Double SparkSQL's Performance
# Gluten: A Middle Layer for Offloading JVM-based SQL Engines' Execution to Native Engines
[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/8452/badge)](https://www.bestpractices.dev/projects/8452)
*<b>This project is still under active development now, and doesn't have a stable release. Welcome to evaluate it.</b>*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also help to insert one blank before this line to address the issue of sentence continuity for OpenSSF badge and the next sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

README.md Outdated
@@ -1,4 +1,4 @@
# Gluten: Plugin to Double SparkSQL's Performance
# Gluten: A Middle Layer for Offloading JVM-based SQL Engines' Execution to Native Engines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Gluten: A Middle Layer for Offloading JVM-based SQL Engines' Execution to Native Engines
# Apache Gluten(Incubating): A Middle Layer for Offloading JVM-based SQL Engines' Execution to Native Engines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for your suggestion!

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE merged commit e47509a into apache:main Mar 11, 2024
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4910_time.csv log/native_master_03_10_2024_3ad58ce14_time.csv difference percentage
q1 36.03 35.86 -0.176 99.51%
q2 23.71 25.95 2.239 109.44%
q3 36.86 36.82 -0.044 99.88%
q4 36.11 38.96 2.846 107.88%
q5 69.52 70.83 1.306 101.88%
q6 7.37 7.41 0.036 100.49%
q7 83.21 83.10 -0.112 99.87%
q8 85.48 85.35 -0.126 99.85%
q9 121.82 118.73 -3.091 97.46%
q10 44.27 42.98 -1.283 97.10%
q11 20.67 21.60 0.928 104.49%
q12 27.01 25.06 -1.951 92.78%
q13 46.78 46.55 -0.234 99.50%
q14 19.86 19.73 -0.132 99.34%
q15 30.67 32.39 1.713 105.59%
q16 14.18 13.72 -0.461 96.75%
q17 100.85 100.46 -0.386 99.62%
q18 140.18 142.43 2.256 101.61%
q19 14.66 13.62 -1.045 92.87%
q20 26.89 26.87 -0.021 99.92%
q21 226.05 225.05 -1.005 99.56%
q22 13.98 14.04 0.055 100.40%
total 1226.17 1227.48 1.314 100.11%

taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Mar 25, 2024
taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Oct 8, 2024
taiyang-li pushed a commit to bigo-sg/gluten that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants