Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6882][CORE] Move Spark / columnar rule list to backend code #6931

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Aug 20, 2024

Issue #6882, part of #6853.

The patch removes planner rule customization APIs from SparkPlanExecApi, and adds a new API RuleApi to allow backends inject their own rule list through a given RuleInjector. After the change, backends will maintain their own complete rule lists so more flexibilities will be gained to developers.

Change list:

  • Remove following APIs in SparkPlanExecApi:
    • genExtendedDataSourceV2Strategies
    • genExtendedQueryStagePrepRules
    • genExtendedAnalyzers
    • genExtendedOptimizers
    • genExtendedStrategies
    • genExtendedColumnarValidationRules
    • genExtendedColumnarTransformRules
    • genExtendedColumnarPostRules
    • genInjectPostHocResolutionRules
    • genInjectExtendedParser
    • genInjectedFunctions
  • Add API trait RuleApi, implemented with CHRuleApi / VeloxRuleApi.
  • Add RuleInjector which is passed to backends through RuleApi from Gluten core. By which backends could inject their own rule lists to Spark and Gluten.

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Aug 20, 2024
Copy link

#6882

@zhztheplayer
Copy link
Member Author

cc @zhanglistar @baibaichen

@zhztheplayer zhztheplayer marked this pull request as ready for review August 20, 2024 06:30
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems CH backend CI is not trigged. cc @baibaichen

@zhztheplayer
Copy link
Member Author

Run Gluten Clickhouse CI

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit 7ad2086 into apache:main Aug 20, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants