-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6887][VL] Daily Update Velox Version (2024_08_28) #7041
Conversation
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
@GlutenPerfBot benchmark |
ACK, will benchmark TPCH/DS on this pull request |
@@ -316,22 +316,27 @@ bool VeloxMemoryManager::tryDestructSafe() { | |||
|
|||
// Velox memory manager considered safe to destruct when no alive pools. | |||
if (veloxMemoryManager_) { | |||
if (veloxMemoryManager_->numPools() > 1) { | |||
if (veloxMemoryManager_->numPools() > 2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note this is due to
facebookincubator/velox@763c19c
@GlutenPerfBot benchmark |
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Upstream Velox's New Commits: afd0ce2bc by Chengcheng Jin, Re-write Spark decimal add, subtract, multiple, divide as simple functions (10619) edf5b9eb4 by Jacob Wujciak-Jens, Remove wall time from BM report (10829) 42c06ca9a by Christian Zentgraf, Fix several build issues in CI when using Clang (10800) 1497dc366 by xiaoxmeng, Add back memory reclaim async callback to remove async dependency on … (10845) f996a0b71 by yan ma, Fix parsing array struct when repetition_type is 'REPEATED' (10753) 81a77f99f by Chengcheng Jin, Change FileInputStream Stats readTimeUs to readTimeNanos (10822) 046726faf by Masha Basmanova, Add registerMapFunction helper function (10857) 763c19c0c by duanmeng, Trace metadata during task creation (10815) 72c4921d2 by Serge Druzkin, Fix minor doc typos in SelectiveColumnReader.h (10835) c74b5e19e by xiaoxmeng, Relax the reclaimed bytes check for hash build (10833)
Upstream Velox's New Commits: