Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7559][VL][UNIFFLE] Set rss.enabled to true in UniffleShuffleManager #7560

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

wForget
Copy link
Member

@wForget wForget commented Oct 16, 2024

What changes were proposed in this pull request?

Fixes: #7559

How was this patch tested?

@wForget
Copy link
Member Author

wForget commented Oct 16, 2024

cc @jackylee-ch @summaryzb could you please take a look?

Copy link

#7559

Copy link
Contributor

@jackylee-ch jackylee-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackylee-ch jackylee-ch merged commit a7908ff into apache:main Oct 17, 2024
43 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_10_17_2024_time.csv log/native_master_10_16_2024_29375d17ad_time.csv difference percentage
q1 14.09 13.36 -0.733 94.80%
q2 15.88 16.32 0.442 102.78%
q3 5.53 4.57 -0.963 82.58%
q4 71.32 70.52 -0.800 98.88%
q5 10.67 9.79 -0.875 91.79%
q6 4.09 3.62 -0.466 88.59%
q7 6.50 8.48 1.979 130.44%
q8 3.49 3.42 -0.064 98.17%
q9 25.09 25.90 0.809 103.22%
q10 8.24 8.97 0.724 108.78%
q11 37.96 37.30 -0.658 98.27%
q12 1.50 1.34 -0.159 89.36%
q13 6.51 6.38 -0.129 98.02%
q14a 48.53 48.57 0.037 100.08%
q14b 43.00 44.66 1.663 103.87%
q15 2.46 2.47 0.005 100.21%
q16 48.83 49.48 0.649 101.33%
q17 5.14 4.73 -0.406 92.11%
q18 7.06 6.85 -0.210 97.02%
q19 2.35 2.24 -0.112 95.24%
q20 1.53 1.58 0.046 102.98%
q21 1.16 1.17 0.004 100.34%
q22 7.90 7.76 -0.138 98.25%
q23a 106.61 107.32 0.706 100.66%
q23b 127.02 127.38 0.363 100.29%
q24a 105.08 115.02 9.945 109.47%
q24b 114.74 113.47 -1.266 98.90%
q25 4.15 5.71 1.565 137.73%
q26 4.02 4.35 0.324 108.04%
q27 5.22 4.98 -0.236 95.47%
q28 31.33 34.01 2.677 108.55%
q29 9.99 9.08 -0.908 90.91%
q30 4.91 4.76 -0.146 97.02%
q31 7.38 6.55 -0.833 88.71%
q32 1.18 1.23 0.056 104.72%
q33 5.43 4.08 -1.352 75.09%
q34 3.83 4.01 0.183 104.77%
q35 9.26 7.89 -1.372 85.19%
q36 5.53 6.16 0.630 111.39%
q37 4.81 5.07 0.262 105.44%
q38 13.53 14.19 0.666 104.92%
q39a 3.08 3.14 0.059 101.93%
q39b 3.42 2.97 -0.448 86.89%
q40 4.03 3.87 -0.160 96.02%
q41 0.65 0.58 -0.074 88.62%
q42 0.97 0.88 -0.087 90.97%
q43 4.66 4.54 -0.116 97.50%
q44 10.40 8.62 -1.783 82.86%
q45 3.21 3.27 0.067 102.08%
q46 4.02 3.85 -0.168 95.83%
q47 18.03 18.27 0.238 101.32%
q48 5.13 5.17 0.033 100.64%
q49 7.34 6.81 -0.529 92.79%
q50 21.84 21.07 -0.770 96.48%
q51 10.12 9.33 -0.784 92.26%
q52 1.10 1.04 -0.057 94.80%
q53 2.47 2.27 -0.198 91.98%
q54 3.57 3.68 0.110 103.07%
q55 1.00 1.01 0.005 100.49%
q56 3.96 4.05 0.096 102.43%
q57 10.59 10.92 0.328 103.10%
q58 2.52 2.50 -0.019 99.23%
q59 10.72 10.58 -0.140 98.70%
q60 4.13 4.13 0.004 100.09%
q61 4.04 4.06 0.023 100.56%
q62 5.04 5.17 0.123 102.44%
q63 2.41 2.38 -0.033 98.63%
q64 64.66 63.21 -1.454 97.75%
q65 16.70 17.45 0.748 104.48%
q66 4.28 4.68 0.407 109.52%
q67 444.23 423.89 -20.343 95.42%
q68 3.94 3.85 -0.086 97.83%
q69 8.18 5.51 -2.670 67.36%
q70 11.46 12.44 0.981 108.56%
q71 2.50 2.42 -0.076 96.94%
q72 217.18 215.07 -2.105 99.03%
q73 2.40 2.45 0.057 102.39%
q74 23.32 23.16 -0.164 99.30%
q75 27.12 27.61 0.484 101.79%
q76 13.14 13.50 0.363 102.76%
q77 2.22 2.04 -0.180 91.89%
q78 50.23 49.30 -0.937 98.14%
q79 4.06 3.88 -0.187 95.40%
q80 11.43 11.38 -0.050 99.56%
q81 4.67 4.61 -0.061 98.69%
q82 6.83 6.86 0.036 100.52%
q83 1.61 1.55 -0.063 96.08%
q84 2.86 2.83 -0.034 98.81%
q85 7.90 7.08 -0.822 89.60%
q86 4.36 4.35 -0.009 99.80%
q87 16.70 14.81 -1.889 88.69%
q88 17.94 18.82 0.876 104.88%
q89 4.24 3.60 -0.640 84.90%
q90 3.06 2.97 -0.083 97.27%
q91 2.51 2.48 -0.025 99.01%
q92 1.24 1.34 0.102 108.24%
q93 40.04 42.21 2.168 105.41%
q94 27.47 26.70 -0.773 97.19%
q9 91.90 90.51 -1.398 98.48%
q5 2.66 2.78 0.120 104.51%
q96 18.37 17.97 -0.394 97.86%
q97 1.97 1.93 -0.044 97.78%
q98 11.09 10.85 -0.242 97.82%
q99 11.09 10.85 -0.242 97.82%
total 2265.76 2244.99 -20.763 99.08%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL][UNIFFLE] DRA does not work in gluten with uniffle
3 participants