feat(algorithm): support random walk in computer #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 23, 2023 18:31
imbajin
changed the title
javeme
reviewed
Oct 24, 2023
| IdListList curValue = sourceVertex.value(); | ||
| curValue.add(path.copy()); | ||
| } | ||
|
|
| this.path.add(vertex.id()); | ||
| } | ||
|
|
||
| public Boolean getIsFinish() { |
| return isFinish.value(); | ||
| } | ||
|
|
||
| public void setIsFinish(Boolean isFinish) { |
| public void setIsFinish(Boolean isFinish) { | ||
| this.isFinish = new BooleanValue(isFinish); | ||
| } | ||
|
|
| } | ||
| return propValues; | ||
| } | ||
|
|
| this.setIfAbsent(params, RandomWalk.OPTION_WALK_LENGTH, | ||
| "3"); | ||
| } | ||
|
|
| } | ||
| } | ||
| } | ||
|
|
| return this.path; | ||
| } | ||
|
|
||
| public void addPath(Vertex vertex) { |
|
|
||
| @Override | ||
| public String name() { | ||
| return "randomWalk"; |
There was a problem hiding this comment.
also keep "page_rank" style?
javeme
reviewed
Oct 25, 2023
| } | ||
|
|
||
| public Boolean isFinish() { | ||
| return isFinish.value(); |
There was a problem hiding this comment.
prefer to call boolValue() instead of value() here and let isFinish() return boolean type.
and please also keep this.isFinish style.
Comment on lines
39
to
42
| this.setIfAbsent(params, RandomWalk.OPTION_WALK_PER_NODE, | ||
| "3"); | ||
| this.setIfAbsent(params, RandomWalk.OPTION_WALK_LENGTH, | ||
| "3"); |
|
note ci error: computer-algorithm/src/main/java/org/apache/hugegraph/computer/algorithm/sampling/RandomWalk.java:111:
Line is longer than 100 characters (found 106). [LineLength] |
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
============================================
- Coverage 85.82% 85.17% -0.66%
- Complexity 3233 3277 +44
============================================
Files 344 349 +5
Lines 12124 12388 +264
Branches 1092 1112 +20
============================================
+ Hits 10406 10552 +146
- Misses 1193 1305 +112
- Partials 525 531 +6
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Add an algorithm: random walk.
Verifying these changes
Please run unit test:
org.apache.hugegraph.computer.algorithm.sampling.RandomWalkTest#testRunAlgorithmDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need