Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): StringEncoding #300

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

diaohancai
Copy link
Contributor

@diaohancai diaohancai commented Dec 27, 2023

Purpose of the PR

  • refactor org.apache.hugegraph.computer.core.util.StringEncoding for next release.

Main Changes

  1. Refactor org.apache.hugegraph.computer.core.util.StringEncoding.
  2. Remove license, notice about org.apache.hugegraph.computer.core.util.StringEncoding.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (e0b484a) 85.03% compared to head (41c7bbd) 85.23%.
Report is 5 commits behind head on master.

Files Patch % Lines
...apache/hugegraph/computer/core/bsp/EtcdClient.java 52.38% 6 Missing and 4 partials ⚠️
.../hugegraph/computer/core/worker/WorkerService.java 85.93% 8 Missing and 1 partial ⚠️
.../hugegraph/computer/core/master/MasterService.java 50.00% 4 Missing and 3 partials ⚠️
...hugegraph/computer/core/util/StringEncodeUtil.java 54.54% 5 Missing ⚠️
...raph/computer/k8s/operator/OperatorEntrypoint.java 81.81% 2 Missing ⚠️
...h/computer/core/network/session/ClientSession.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     85.03%   85.23%   +0.20%     
- Complexity     3296     3301       +5     
============================================
  Files           349      349              
  Lines         12485    12459      -26     
  Branches       1130     1123       -7     
============================================
+ Hits          10616    10620       +4     
+ Misses         1329     1300      -29     
+ Partials        540      539       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NOTICE Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we remove the refer, we should delete all unnecessary NOTICE info from JG

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check carefully if any code may use it~ (just a reminder)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, delete all of the JG NOTICE info

@diaohancai diaohancai requested a review from imbajin December 27, 2023 14:08
@JackyYangPassion JackyYangPassion merged commit 6c07251 into apache:master Dec 29, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants