Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base-ref/head-ref missed in dependency-review on schedule push #304

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Mar 4, 2024

Purpose of the PR

Because the scheduled task default to running on the master branch, the related parameters (base_ref/head_ref) were missing

image
img_v3_028l_89f40cef-02e6-4381-a45d-4ab0b0c1f1cg
image

ref:
1. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
2. #516

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Mar 4, 2024
@msgui msgui changed the title fix: base-ref/head-ref missed in dependency-check-ci on schedule push fix: base-ref/head-ref missed in dependency-review on schedule push Mar 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2024
@imbajin imbajin requested a review from coderzc March 4, 2024 11:12
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (e0b484a) to head (6c18e4f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
+ Coverage     85.03%   85.17%   +0.14%     
- Complexity     3296     3299       +3     
============================================
  Files           349      349              
  Lines         12485    12461      -24     
  Branches       1130     1123       -7     
============================================
- Hits          10616    10614       -2     
+ Misses         1329     1306      -23     
- Partials        540      541       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderzc coderzc merged commit f64a608 into apache:master Mar 11, 2024
9 checks passed
@msgui msgui deleted the fix-dependency-review branch March 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants