Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1123:unify maven projects configuration #5873

Merged
merged 4 commits into from
May 14, 2024

Conversation

jstastny-cz
Copy link
Contributor

@jstastny-cz jstastny-cz commented Apr 26, 2024

Related to

Part of ensemble:

Changes

  • Use latest org.apache:apache parent
  • Remove repositories and distributionManagement sections
  • Remove overrides for maven-deploy-plugin version
  • Adjust out of date developers/contributors information.

Follow-up

  • Adjust CI configuration
    • Should be safe to split, current deploy procedure does not utilize the distribution/repositories configuration from projects.

@rodrigonull rodrigonull self-requested a review May 2, 2024 20:27
Copy link
Contributor

@rodrigonull rodrigonull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question, do we need to update the maven settings file on Jenkins or is it already ready to work with these changes?

@jstastny-cz jstastny-cz merged commit 229f529 into apache:main May 14, 2024
8 of 10 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Jun 10, 2024
* kie-issues#1123:unify maven projects configuration

* adjust deploy operation

* Revert "adjust deploy operation"

This reverts commit 258c819.

* switch to https scm connection

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants