-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-1299: added fallback UI when server unavailable #131
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
packages/management-console/src/components/Molecules/NoServerComponent/NoServerComponent.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import React, { useState } from 'react'; | ||
| import { | ||
| PageSection, | ||
| Bullseye, | ||
| EmptyState, | ||
| EmptyStateIcon, | ||
| EmptyStateVariant, | ||
| Button, | ||
| EmptyStateBody, | ||
| Title, | ||
| Page, | ||
| SkipToContent, | ||
| PageSidebar, | ||
| PageHeader, | ||
| Nav, | ||
| NavList, | ||
| NavItem, | ||
| Brand, | ||
| } from '@patternfly/react-core'; | ||
| import { | ||
| ExclamationCircleIcon | ||
| } from '@patternfly/react-icons'; | ||
| import { BrowserRouter as Router, Link } from 'react-router-dom'; | ||
| import Avatar from '../../Atoms/AvatarComponent/AvatarComponent'; | ||
| import PageToolbarComponent from '../../Organisms/PageToolbarComponent/PageToolbarComponent'; | ||
| import managementConsoleLogo from '../../../static/managementConsoleLogo.svg'; | ||
|
|
||
| const NoServerComponent = (props) => { | ||
| const [isNavOpen, setIsNavOpen] = useState(true); | ||
| const onNavToggle = () => { | ||
| setIsNavOpen(!isNavOpen); | ||
| }; | ||
|
|
||
| const Header = ( | ||
| <PageHeader | ||
| logo={<Brand | ||
| src={managementConsoleLogo} | ||
| alt="Management Console Logo" | ||
| />} | ||
| toolbar={<PageToolbarComponent />} | ||
| avatar={<Avatar />} | ||
| showNavToggle | ||
| isNavOpen={isNavOpen} | ||
| onNavToggle={onNavToggle} | ||
| /> | ||
| ); | ||
|
|
||
| const PageNav = ( | ||
| <Nav aria-label="Nav" theme="dark"> | ||
| <NavList> | ||
| <NavItem> | ||
| <Link to="/ProcessInstances">Process Instances</Link> | ||
| </NavItem> | ||
| <NavItem> | ||
| <Link to="/DomainExplorer">Domain Explorer</Link> | ||
| </NavItem> | ||
| </NavList> | ||
| </Nav> | ||
| ); | ||
| const Sidebar = ( | ||
| <PageSidebar nav={PageNav} isNavOpen={isNavOpen} theme="dark" /> | ||
| ); | ||
|
|
||
| const pageId = 'main-content-page-layout-default-nav'; | ||
| const PageSkipToContent = ( | ||
| <SkipToContent href={`#${pageId}`}>Skip to Content</SkipToContent> | ||
| ); | ||
|
|
||
| return ( | ||
| <> | ||
| <Router> | ||
| <Page | ||
| header={Header} | ||
| skipToContent={PageSkipToContent} | ||
| mainContainerId={pageId} | ||
| sidebar={Sidebar} | ||
| isManagedSidebar | ||
| className="kogito-management-console--dashboard-page" | ||
| > | ||
| <PageSection variant="light"> | ||
| <Bullseye> | ||
| <EmptyState variant={EmptyStateVariant.full}> | ||
| <EmptyStateIcon | ||
| icon={ExclamationCircleIcon} | ||
| size="md" | ||
| color="var(--pf-global--danger-color--100)" /> | ||
| <Title headingLevel="h1" size="4xl">Error connecting server</Title> | ||
| <EmptyStateBody> | ||
| The management console could not access the server to display content. | ||
| </EmptyStateBody> | ||
| <EmptyStateBody> | ||
| Try reloading the page, or contact your administrator for more information. | ||
| </EmptyStateBody> | ||
| <Button variant="primary" onClick={() => window.location.reload()}> | ||
| Refresh | ||
| </Button> | ||
| </EmptyState> | ||
| </Bullseye> | ||
| </PageSection> | ||
| </Page> | ||
| </Router> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default NoServerComponent; |
4 changes: 4 additions & 0 deletions
4
...nagement-console/src/components/Molecules/ServerErrorsComponent/ServerErrorsComponent.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .kogito-management-console--Server-Errors__text-color { | ||
| color: var(--pf-global--primary-color--100); | ||
| cursor: pointer | ||
| } |
51 changes: 51 additions & 0 deletions
51
...nagement-console/src/components/Molecules/ServerErrorsComponent/ServerErrorsComponent.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import React,{useState} from 'react'; | ||
|
|
||
| import { | ||
| PageSection, | ||
| Bullseye, | ||
| EmptyState, | ||
| EmptyStateIcon, | ||
| EmptyStateVariant, | ||
| Button, | ||
| EmptyStateBody, | ||
| Title, | ||
| Popover, | ||
| ClipboardCopy, | ||
| ClipboardCopyVariant | ||
| } from '@patternfly/react-core'; | ||
| import { | ||
| ExclamationCircleIcon | ||
| } from '@patternfly/react-icons'; | ||
| import './ServerErrorsComponent.css'; | ||
| import {useHistory} from 'react-router-dom'; | ||
|
|
||
| const ServerErrorsComponent = (props) => { | ||
| const [displayError, setDisplayError] = useState(false) | ||
| const history = useHistory(); | ||
|
|
||
| return ( | ||
| <PageSection variant="light"> | ||
| <Bullseye> | ||
| <EmptyState variant={EmptyStateVariant.full}> | ||
| <EmptyStateIcon | ||
| icon={ExclamationCircleIcon} | ||
| size="md" | ||
| color="var(--pf-global--danger-color--100)" /> | ||
| <Title headingLevel="h1" size="4xl">Error fetching data</Title> | ||
| <EmptyStateBody> | ||
| An error occurred while accessing data. <Button variant="link" isInline onClick={() => setDisplayError(!displayError)}>See more details</Button> | ||
| </EmptyStateBody> | ||
| {displayError &&<EmptyStateBody> | ||
| <ClipboardCopy isCode variant={ClipboardCopyVariant.expansion} isExpanded={true} className="pf-u-text-align-left">{JSON.stringify(props.message)}</ClipboardCopy> | ||
| </EmptyStateBody>} | ||
| <Button variant="primary" onClick={() => history.goBack()}> | ||
| Go back | ||
| </Button> | ||
| </EmptyState> | ||
| </Bullseye> | ||
|
|
||
| </PageSection> | ||
| ) | ||
| } | ||
|
|
||
| export default ServerErrorsComponent; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sara4994 The new route "/Process*" includes "/ProcessInstances*. Here I think we have to remove the line: router.route("/ProcessInstances*").handler(ctx -> handle(ctx)); and let just the new route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmirasch but actually these two are different routes that directs us to two different pages, '/ProcessInstances' will take us to process list page and '/Process' will take us to process details page. should we still remove the line: router.route("/ProcessInstances*").handler(ctx -> handle(ctx));?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sara4994 point is that /Process* will also match the same urls, because of the pattern matching, so the line with /ProcessInstances* should be removed or you can simply update that one.