Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump microsoft/setup-msbuild from 1 to 2 #1977

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 5, 2024

Bumps microsoft/setup-msbuild from 1 to 2.

Release notes

Sourced from microsoft/setup-msbuild's releases.

v2

This is a major version bump with no functionality changes. The major version change is due to moving to node20 for the node version per the deprecation announcement for GitHub Actions (https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/). This change from node16 to node20 could cause breaking changes to other workflow actions steps (see #125) running and needing/leveraging expected functionality in node16 and thus as a safe boundary, changing the version here.

Full Changelog: microsoft/setup-msbuild@v1.3...v2

v1.3.3

This is a patch update that reverts the node16->node20 change which introduced unintended breaking changes for users of this action. The v1, v1.3 tags have been updated to this release as well.

Full Changelog: microsoft/setup-msbuild@v1.3.2...v1.3.3

v1.3.2

What's Changed

New Contributors

Full Changelog: microsoft/setup-msbuild@v1.3.1...v1.3.2

v1.3.1

What's Changed

New Contributors

Full Changelog: microsoft/setup-msbuild@v1.2...v1.3.1

v1.1.3 - Updating toolkit for output variables

Updates the GitHub Actions @actions/core toolkit to latest version to accommodate deprecated set-output calls.

v1.1.2 - Update to node16

This updates to using node16 per deprecation notice for GitHub Actions

v1.1.1

Adding msbuild-architecture to select specific architecture for host agents when running with Visual Studio 2022 (VS 17.0)

v1.0.3

This release adds the ability for another input to look for pre-release versions of Visual Studio by specifying vs-prerelease: true as an input.

v1.0.2 Release

Updates Actions core toolkit to fix vulnerability on environment/path variable setting.

v1.0.1 Release

Fixes some input parameters and resolving dependency updates.

Thanks @​heaths for the contribution of fixes!

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 5, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 5, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1977 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1977/1/display/redirect

Test results:

  • PASSED: 2859
  • FAILED: 2

Those are the test failures:

org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null

@yesamer
Copy link
Contributor

yesamer commented Mar 14, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/github_actions/microsoft/setup-msbuild-2 branch from 351134c to 37dc4c0 Compare March 14, 2024 15:55
@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 14, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1977 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1977/2/display/redirect

Test results:

  • PASSED: 2822
  • FAILED: 1

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.jobs.CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded 1 expectation failed.
Expected status code <200> but was <404>.

@yesamer
Copy link
Contributor

yesamer commented Mar 15, 2024

@dependabot rebase

Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1 to 2.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](microsoft/setup-msbuild@v1...v2)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/microsoft/setup-msbuild-2 branch from 37dc4c0 to 0ae6d10 Compare March 15, 2024 09:08
@yesamer yesamer merged commit 652d48e into main Mar 15, 2024
5 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/microsoft/setup-msbuild-2 branch March 15, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants