Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#923] Add index to foreign key columns to improve performance in postgresql #1985

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

martinweiler
Copy link
Contributor

@martinweiler martinweiler commented Feb 12, 2024

@martinweiler martinweiler added the Data Index Data Index related issue label Feb 12, 2024
@porcelli porcelli requested a review from pefernan February 13, 2024 00:08
@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 13, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1985 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1985/1/display/redirect

Test results:

  • PASSED: 2822
  • FAILED: 4

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin for all your work on this perfomance issue

@martinweiler martinweiler merged commit 990f29f into apache:main Feb 14, 2024
7 checks passed
fjtirado pushed a commit to fjtirado/kogito-apps that referenced this pull request Feb 20, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Index Data Index related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance postgresql scripts with index for FK constraints in data-index
4 participants