-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-1084] User eager fetching in ProcessDefinitionEntity to avoid transaction errors #2032
[incubator-kie-issues-1084] User eager fetching in ProcessDefinitionEntity to avoid transaction errors #2032
Conversation
I am not sure this is the best approach. |
@martinweiler I think removing the three collections from toString method will be enough. Lets keep loading of collections lazy. |
...storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/model/ProcessDefinitionEntity.java
Outdated
Show resolved
Hide resolved
@@ -208,7 +209,6 @@ public String toString() { | |||
", roles=" + roles + | |||
", addons=" + addons + | |||
", endpoint='" + endpoint + '\'' + | |||
", nodes='" + nodes + '\'' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing roles and addons from toString will do the trick
Im wondering if to string should just print the id and the version (the composite key) of the process definition to avoid further problem. That will be enough for logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado ok, let's just remove the fields that are lazy loaded from the toString method
…y.toString to avoid transaction errors due to lazy loading
5a4faca
to
bbfdfbb
Compare
…y.toString to avoid transaction errors due to lazy loading (apache#2032)
Fixes apache/incubator-kie-issues#1084