Revert distinguish PR status for kogito-runtimes #2798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi we will need to revert this due to an issue that github itself hasn't fixed.
The way action-surefire-report or action-junit-report publish/annotate test failures is using github's check api. Whenever a workflow is run it creates something called a check suite which contains check runs. These check runs are responsible for letting us update github action status. Now these actions give us 2 options to update github action status using check runs - use existing "in_progress" check runs or create a new one.
Both these problems seem to be known issues:
The creating check run option would have worked but github api does not let us specify the workflow id we want to create the check run for. It only lets us specify the head_sha but again we can have multiple check suites associated with it since we have multiple workflows triggered for a PR. This has been documented in the community but there hasn't been an update from Github for years now:
I do have some workarounds in mind but I think it is better to try them on a simpler repository. Until then we can keep the
surefire.yml
(we should disable the workflow tho) and thekogito-pipeline
changes since they shouldn't impact the existing PR checks once this PR is merged