Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3725] Setting leaveTime in Split and Fault node instance #3726

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[Fix #3725] Setting leaveTime in Split and Fault node instance #3726

merged 1 commit into from
Oct 15, 2024

Conversation

fjtirado
Copy link
Contributor

Fix #3725

gmunozfe
gmunozfe approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great catch @fjtirado !

@fjtirado fjtirado merged commit 342ef3b into apache:main Oct 15, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 24, 2024
@fjtirado @rgdoliveira
[Fix apache#3725] Setting leaveTime in Split and Fault node instance (a…
c644dd8 
…pache#3726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MetricProcessEventListener fails if node has not set leaveDate before calling listeners
3 participants
@fjtirado @ricardozanini @gmunozfe