Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1551] Deadlines for Human Task #3752

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

elguardian
Copy link
Contributor

@elguardian elguardian force-pushed the incubator-kie-issues-1551 branch from cad1420 to 50eee02 Compare October 25, 2024 09:38
@apache apache deleted a comment from kie-ci3 Oct 26, 2024
@apache apache deleted a comment from kie-ci3 Oct 26, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1551 branch from 3990f81 to e54cf30 Compare October 31, 2024 11:55
@apache apache deleted a comment from kie-ci3 Oct 31, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1551 branch from e54cf30 to 0e32626 Compare November 4, 2024 08:20
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 6, 2024
@apache apache deleted a comment from kie-ci3 Nov 7, 2024
@apache apache deleted a comment from kie-ci3 Nov 11, 2024
@apache apache deleted a comment from kie-ci3 Nov 13, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1551 branch from 5911a4e to 63fe004 Compare November 13, 2024 11:56
@pefernan pefernan self-requested a review November 15, 2024 08:09
@apache apache deleted a comment from kie-ci3 Nov 15, 2024



/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed



create table jbpm_user_tasks_reassignment_timer (
task_id varchar(50) not null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind align the column types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligned

@@ -29,7 +36,6 @@
})
@AssociationOverride(name = "taskInstance",
joinColumns = @JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "jbpm_user_tasks_outputs_tid")))
@IdClass(TaskDataEntityPK.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need:
@IdClass(TaskNamedDataEntityPK.class)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some IT tests need to be fixed
Approved when green

@apache apache deleted a comment from kie-ci3 Nov 17, 2024
@apache apache deleted a comment from kie-ci3 Nov 17, 2024
@elguardian elguardian requested a review from pefernan November 18, 2024 11:29
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@elguardian elguardian merged commit a3ac6e7 into apache:main Nov 18, 2024
5 of 6 checks passed
@elguardian elguardian deleted the incubator-kie-issues-1551 branch November 18, 2024 13:09
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 18, 2024
pefernan pushed a commit to pefernan/kogito-runtimes that referenced this pull request Nov 26, 2024
pefernan pushed a commit to pefernan/kogito-runtimes that referenced this pull request Nov 26, 2024
…s-1551

[incubator-kie-issues-1551] Deadlines for Human Task (apache#3752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlines for Human Task
3 participants