Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO_ISSUE] fix constraints names #3753

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

pefernan
Copy link
Contributor

Just fixing two constraints names for consistency with other tables.

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@@ -42,7 +42,7 @@ public class AttachmentEntity {
private Date updatedAt;

@ManyToOne
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_attachment_tid"))
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_attachments_tid"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_attachments_tid"))
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_tasks_attachments_tid"))

@@ -40,7 +40,7 @@ public class CommentEntity {
private Date updatedAt;

@ManyToOne(optional = false)
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_comment_tid"))
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_comments_tid"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_task_comments_tid"))
@JoinColumn(name = "task_id", foreignKey = @ForeignKey(name = "fk_user_tasks_comments_tid"))


alter table if exists jbpm_user_tasks_comments
add constraint fk_user_task_comment_tid foreign key (task_id) references jbpm_user_tasks(id) on delete cascade;
add constraint fk_user_task_comments_tid foreign key (task_id) references jbpm_user_tasks(id) on delete cascade;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add constraint fk_user_task_comments_tid foreign key (task_id) references jbpm_user_tasks(id) on delete cascade;
add constraint fk_user_tasks_comments_tid foreign key (task_id) references jbpm_user_tasks(id) on delete cascade;

@pefernan pefernan requested a review from yesamer October 25, 2024 14:26
@pefernan pefernan merged commit 79b771a into apache:main Oct 25, 2024
5 of 6 checks passed
@pefernan pefernan deleted the no_issue_ddls_consistency branch October 25, 2024 18:31
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Nov 7, 2024
* [NO_ISSUE] fix constraints names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants