-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kie-issues#1549: kn-workflow-plugin check for the presence of an imag…
…e in the local Docker image does not cover all cases
- Loading branch information
1 parent
8b94c56
commit d3eb631
Showing
4 changed files
with
108 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package common | ||
|
|
||
| import ( | ||
| "context" | ||
| "github.com/docker/docker/api/types" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/mock" | ||
|
|
||
| "testing" | ||
| ) | ||
|
|
||
| type MockDockerClient struct { | ||
| mock.Mock | ||
| } | ||
|
|
||
| func (m *MockDockerClient) ImageList(ctx context.Context, options types.ImageListOptions) ([]types.ImageSummary, error) { | ||
| args := m.Called(ctx, options) | ||
| return args.Get(0).([]types.ImageSummary), args.Error(1) | ||
| } | ||
|
|
||
| func TestCheckImageExists(t *testing.T) { | ||
|
|
||
| tests := []struct { | ||
| lookup string | ||
| images []string | ||
| expected bool | ||
| }{ | ||
| {"docker.io/apache/incubator-kie-sonataflow-devmode:main", []string{"docker.io/apache/incubator-kie-sonataflow-devmode:main"}, true}, | ||
| {"docker.io/apache/incubator-kie-sonataflow-devmode:main", []string{"apache/incubator-kie-sonataflow-devmode:main"}, true}, | ||
|
|
||
| {"docker.io/apache/incubator-kie-sonataflow-devmode", []string{"docker.io/apache/incubator-kie-sonataflow-devmode:latest"}, true}, | ||
| {"docker.io/apache/incubator-kie-sonataflow-devmode", []string{"apache/incubator-kie-sonataflow-devmode:latest"}, true}, | ||
|
|
||
| {"apache/incubator-kie-sonataflow-devmode:main", []string{"docker.io/apache/incubator-kie-sonataflow-devmode:main"}, true}, | ||
| {"apache/incubator-kie-sonataflow-devmode:main", []string{"apache/incubator-kie-sonataflow-devmode:main"}, true}, | ||
|
|
||
| {"docker.io/apache/incubator-kie-sonataflow-devmode:main", []string{"incubator-kie-sonataflow-devmode:main"}, false}, | ||
| {"docker.io/apache/incubator-kie-sonataflow-devmode", []string{"incubator-kie-sonataflow-devmode:latest"}, false}, | ||
| {"apache/incubator-kie-sonataflow-devmode:main", []string{"incubator-kie-sonataflow-devmode:main"}, false}, | ||
| } | ||
|
|
||
| for _, test := range tests { | ||
| ctx := context.Background() | ||
| mockClient := new(MockDockerClient) | ||
|
|
||
| mockClient.On("ImageList", ctx, mock.Anything).Return([]types.ImageSummary{ | ||
| { | ||
| RepoTags: test.images, | ||
| }, | ||
| }, nil) | ||
|
|
||
| exists, err := CheckImageExists(mockClient, ctx, test.lookup) | ||
| assert.NoError(t, err, "Error should be nil") | ||
| assert.True(t, exists == test.expected, "Expected %t, got %t", test.expected, exists) | ||
| } | ||
| } |