-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#2601: [kn-plugin-workflow] Minify the openAPI spec files to trim operations only used by the workflows in the current project #2711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take a few openapi specs as an example for tests from here:
https://github.com/quarkiverse/quarkus-openapi-generator/tree/main/client/integration-tests
Things that should be included in the test cases:
- Full openapi spec
- Minified spec
- Workflow referencing the spec
- Adding another openapi operation to the workflow and recheck if the new operation has been added to the minified version.
packages/kn-plugin-workflow/pkg/command/deploy_undeploy_common.go
Outdated
Show resolved
Hide resolved
@ricardozanini I have added |
2aa9cc3
to
651ed2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I left two minor suggestions.
…o trim operations only used by the workflows in the current project
651ed2d
to
8e6fc38
Compare
@domhanak can you please verify this? |
Yup, working on it, investigating some issue with compilation after the minifications, Will let you know. |
Documentation of the command
Functional
More information about testing to follow, I will update the comment with latest info. |
…o trim operations only used by the workflows in the current project (apache#2711) Co-authored-by: Dmitrii Tikhomirov <treblereel@Dmitriis-MacBook-Pro.local>
…o trim operations only used by the workflows in the current project (apache#2711) (#62) Co-authored-by: Dmitrii Tikhomirov <treblereel@users.noreply.github.com> Co-authored-by: Dmitrii Tikhomirov <treblereel@Dmitriis-MacBook-Pro.local>
Fix #2601
tests are missed atm, I'll add it in a couple of days