[NEMO-321] Fix the data skew pass metric mismatch #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-321: Fix the data skew pass metric mismatch
Major changes:
DataSkewRuntimePass
access to the partitioning logic by movingPartitioner
interface and the implementations from runtime executor to runtime common.MetricCollectionVertex
and the data metric understood byDataSkewRuntimePass
is caused by the fact that the partitioning logic is hidden from both components.Minor changes to note:
MetricCollection
property.DynamicOptimization
property (not needed).Tests for the changes:
Other comments:
Closes #188