Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEMO-433] Improvement of Task Metrics and Collecting Them For Sampling #289

Merged
merged 9 commits into from
Mar 7, 2020
Merged

[NEMO-433] Improvement of Task Metrics and Collecting Them For Sampling #289

merged 9 commits into from
Mar 7, 2020

Conversation

hwarim-hyun
Copy link
Contributor

@hwarim-hyun hwarim-hyun commented Mar 3, 2020 •
edited
Loading

JIRA: NEMO-433: Improvement of Task Metrics and Collecting Them For Sampling

Major changes:

  • Added some new metrics (task, job) and usages of them
  • Added new execution property for DTS (vertex, edge)

Minor changes to note:

  • changed checkstyle grammer for windows
  • BlockInputReader now contains metricMessageSender for sending some task metrics, and it has whole task id instead of just task index.

Tests for the changes:

  • Tests related to BlockInputReader has changed: TaskExecutorTest, DataTransferTest

Other comments:

  • N/A

Closes #289

wonook
wonook requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@wonook wonook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! I've done my first pass.

runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/JobMetric.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/plan/StageEdge.java Outdated Show resolved Hide resolved
...e/executor/src/test/java/org/apache/nemo/runtime/executor/datatransfer/DataTransferTest.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/plan/StageEdge.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/plan/StageEdge.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/TaskMetric.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/TaskMetric.java Outdated Show resolved Hide resolved
runtime/common/src/main/java/org/apache/nemo/runtime/common/metric/TaskMetric.java Outdated Show resolved Hide resolved
@hwarim-hyun hwarim-hyun changed the title NEMO-433: Improvement of Task Metrics and Collecting Them For Sampling [NEMO-433] Improvement of Task Metrics and Collecting Them For Sampling Mar 6, 2020
wonook
wonook approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@wonook wonook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work! I'll merge.

@wonook wonook merged commit e64d0d0 into apache:master Mar 7, 2020
@wonook wonook deleted the DTS_PR1_taskSampling branch March 7, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonook wonook wonook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwarim-hyun @wonook