[NEMO-456] Remove unnecessary shuffling processes in Combine transformation #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and PipelineTranslator. Removed keyword final in GBKTransform to make it extendable.
taegeonum
requested changes
Oct 17, 2020
...nd/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslationContext.java
Outdated
Show resolved
Hide resolved
…bator-nemo into 456-RemoveShufflinginCombine Merging
taegeonum
reviewed
Oct 17, 2020
| @@ -275,7 +275,7 @@ DAGBuilder getBuilder() { | |||
| if (srcTransform instanceof FlattenTransform) { | |||
| return CommunicationPatternProperty.Value.ONE_TO_ONE; | |||
| } | |||
| if (dstTransform instanceof GBKTransform | |||
| if ((dstTransform instanceof GBKTransform && !((GBKTransform) dstTransform).getIsPartialCombining()) | |||
There was a problem hiding this comment.
Could you please add some comments here?
There was a problem hiding this comment.
Yes, I added them. Thank you.
|
Kudos, SonarCloud Quality Gate passed!
|
taegeonum
approved these changes
Oct 17, 2020
taegeonum
pushed a commit
that referenced
this pull request
Oct 18, 2020
JIRA: [NEMO-460: Setting coders in CombinePerKey transformation](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-460) **Major changes:** - Added the additional parameter "inputCoder" for GBKTransform constructor. - Fixed the input coder and the output coder for the partial combine transform and the final combine transform. **Minor changes to note:** - Fixed the main output TupleTags for the partial combine transform and the final combine transform. **Tests for the changes:** - Current tests suffice. **Other comments:** - This needs to be merged after merging #302 Closes #303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-456: Remove unnecessary shuffling processes in Combine transformation
Major changes:
Tests for the changes:
Closes #302