Skip to content

Commit

Permalink
chore(go-client): add generation thrift files of go-client (#1917)
Browse files Browse the repository at this point in the history
#1881

By uploading generation thrift files, the go client can be used directly by users through "go get" without the need to compile it locally.
  • Loading branch information
lengyuexuexuan authored Jun 20, 2024
1 parent 8fd8902 commit 44e8350
Show file tree
Hide file tree
Showing 30 changed files with 52,636 additions and 10 deletions.
5 changes: 0 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,6 @@ package-lock.json
# ============= #
go-client/bin
go-client/coverage.txt
go-client/idl/admin/
go-client/idl/cmd/
go-client/idl/radmin/
go-client/idl/replication/
go-client/idl/rrdb/

thirdparty/output/

Expand Down
10 changes: 6 additions & 4 deletions .licenserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ header:
- '**/*.pdf'
# Special files for golang.
- '**/go.sum'
# TODO(wangdan): Generated files for go client, could generate dynamically?
- 'go-client/idl/base/GoUnusedProtection__.go'
- 'go-client/idl/base/dsn_err_string.go'
- 'go-client/idl/base/rocskdb_err_string.go'
- 'go-client/idl/admin/**'
- 'go-client/idl/base/**'
- 'go-client/idl/cmd/**'
- 'go-client/idl/radmin/**'
- 'go-client/idl/replication/**'
- 'go-client/idl/rrdb/**'
# Special files for nodejs.
- '**/.npmigonre'
# Special files for python.
Expand Down
2 changes: 1 addition & 1 deletion go-client/admin/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func TestAdmin_ListNodes(t *testing.T) {
for i, node := range nodes {
// Each node should be alive.
assert.Equal(t, admin.NodeStatus_NS_ALIVE, node.Status)
actualReplicaServerPorts[i] = node.Address.GetPort()
actualReplicaServerPorts[i] = node.GetNode().GetPort()
}

// Match elements without extra ordering.
Expand Down
6 changes: 6 additions & 0 deletions go-client/idl/admin/GoUnusedProtection__.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions go-client/idl/admin/backup-consts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 44e8350

Please sign in to comment.