feat: support to use jemalloc while building pegasus #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great！ |
foreverneverer
previously approved these changes
Jul 16, 2022
Closed
acelyc111
reviewed
Jul 18, 2022
acelyc111
approved these changes
Jul 18, 2022
foreverneverer
approved these changes
Jul 19, 2022
Closed
This was referenced Aug 22, 2022
ZhongChaoqiang
pushed a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #819.
Previously we've supported jemalloc while building rDSN (XiaoMi/rdsn#910). However, building pegasus with jemalloc enabled will lead to the following problem:
The reason can be described like this: cmake file for RocksDB had been generated to enable jemalloc (JeMalloc::JeMalloc);
on the other hand, however, rDSN was not told that jemalloc should be enabled, since pegasus didn't pass
USE_JEMALLOCto rDSN.Enabling jemalloc while building pegasus can be implemented in this way: since
dsn_common_setup()are called insrc/CMakeLists.txtbefore building executables, using jemalloc for pegasus can be supported by passing the optionUSE_JEMALLOCtordsn/bin/dsn.cmake.