-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build): remove 'rdsn' from build and test commands #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
changed the title
init rm_rdsn_cmakelist
refactor(build): remove 'rdsn' in build and test commands
Aug 3, 2022
acelyc111
force-pushed
the
rm_rdsn_cmakelist
branch
2 times, most recently
from
August 8, 2022 23:33
87476e4
to
46f6bdc
Compare
acelyc111
changed the title
refactor(build): remove 'rdsn' in build and test commands
refactor(build): remove 'rdsn' from build and test commands
Aug 8, 2022
acelyc111
force-pushed
the
rm_rdsn_cmakelist
branch
from
August 8, 2022 23:48
ebf55a9
to
1d65ce7
Compare
acelyc111
force-pushed
the
rm_rdsn_cmakelist
branch
from
August 10, 2022 04:03
282b0a8
to
4097de1
Compare
hycdong
previously approved these changes
Aug 11, 2022
LGTM~ Besides, I have following suggestions:
|
|
hycdong
approved these changes
Aug 11, 2022
levy5307
approved these changes
Aug 12, 2022
foreverneverer
pushed a commit
that referenced
this pull request
Aug 18, 2022
ZhongChaoqiang
added a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1053
This patch is planning to remove 'rdsn' from build and test commands. After doing this, the CI will last longer, so I have to the following work to reduce the effect:
a. shorten names, it will be easier to read on Web
b. split 'test' into 'build' and 'test'
c. remove some self-hosted runner configs
d. use
actions/cache@v3
to speed up build stagede. remove changes check on rdsn directory
f. make -j parameter with N cpus instead N/2
g. use
actions/upload-artifact@v3
andactions/download-artifact@v3
to pass test artifacts from build job to test jobh. use
matrix
to run test parallely to reduce test last time, and make re-run cheaper (and also add some missing test cases in run.sh)i. remove LSAN since it's included by ASAN
a. unify rdsn and pegasus cmakelists
b. add ccache detection and configs in cmake
c. adjust includes and links
d. make
pegasus_geo_test
can be run by shell which is the unify waye. remove src/rdsn/CMakeLists.txt
a. remove 'rdsn' from run.sh for both build and test functions
b. re-org thrift generating and git_commit.h generating
c. use different build dirs for different build types, then you can switch build types with lower cost (NOTE: you have to remove
src/builder
directory after this patch)d. make
wget
more robust (bywget -T 10 -t 5
) Pegasus unit test failed for download hadoop failed #1095a. move templates to header files (
src/rdsn/src/meta/meta_service.h
)b. other cmake and cpp files