refactor(function_test): use test_util to reduce duplicate code #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
changed the title
levy5307
reviewed
Sep 23, 2022
| inline void run_cmd(const std::string &cmd, std::string *output = nullptr) | ||
| { | ||
| std::stringstream ss; | ||
| int ret = dsn::utils::pipe_execute(cmd.c_str(), ss); |
There was a problem hiding this comment.
In my opinion, it's better to reduce the usage of raw pointer. Using std::string instead is a better choice.
There was a problem hiding this comment.
Agree, we can refactor functions like pipe_execute in another patch, this patch only refactor function tests.
levy5307
approved these changes
Sep 23, 2022
foreverneverer
approved these changes
Sep 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1166
This is a flow up to #1149, now refactoring these function tests to inherit from test_util to reduce duplicate code.
And also include some other non-functional refactors.